Skip to content

Remove securityGroupOverride validation for NLB #17383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove securityGroupOverride validation for NLB #17383

wants to merge 1 commit into from

Conversation

h3poteto
Copy link
Contributor

@h3poteto h3poteto commented May 2, 2025 •
edited
Loading

fix #17207

NLBs did not support security groups in the past. However, AWS now supports specifying a security group for an NLB. When kops creates a new cluster with an NLB, it also creates a security group for it by default.
Therefore, I believe we can now allow securityGroupOverride for NLBs in kops as well.

Please let me know if I'm overlooking anything or if there are any concerns with this approach.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @h3poteto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab May 2, 2025 15:47
@h3poteto h3poteto marked this pull request as ready for review May 2, 2025 15:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus May 2, 2025 15:52
@hakman
Copy link
Member

hakman commented May 2, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2025
@justinsb
Copy link
Member

justinsb commented May 3, 2025

I think this is a feature so should not delay releases? That said it seems pretty safe (as it's only validation IIUC), so I don't mind if we backport it to (say) 1.32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@zetaab zetaab Awaiting requested review from zetaab

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees
No one assigned
Labels
area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

securityGroupOverride should be allowed for network load balancer
4 participants
@h3poteto @k8s-ci-robot @hakman @justinsb